This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Duplicated symbols when linking embedded Python with libexpat
Type: Stage: commit review
Components: Build, XML Versions: Python 3.11, Python 3.10, Python 3.9, Python 3.8, Python 3.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: corona10, gregory.p.smith, lukasz.langa, miss-islington, ned.deily, yilei
Priority: normal Keywords: patch

Created on 2022-02-17 23:35 by yilei, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 31397 merged yilei, 2022-02-17 23:47
PR 31416 closed miss-islington, 2022-02-18 22:33
PR 31417 merged miss-islington, 2022-02-18 22:33
PR 31418 merged miss-islington, 2022-02-18 23:07
PR 31419 merged miss-islington, 2022-02-18 23:07
PR 31420 merged gregory.p.smith, 2022-02-18 23:33
Messages (8)
msg413464 - (view) Author: Yilei Yang (yilei) * Date: 2022-02-17 23:35
The libexpat 2.4.1 upgrade from https://bugs.python.org/issue44394 introduced the following new exported symbols:

testingAccountingGetCountBytesDirect
testingAccountingGetCountBytesIndirect
unsignedCharToPrintable
XML_SetBillionLaughsAttackProtectionActivationThreshold
XML_SetBillionLaughsAttackProtectionMaximumAmplification

We need to adjust Modules/expat/pyexpatns.h

(The newer libexpat upgrade https://bugs.python.org/issue46400 has no new symbols).

I'll send a PR.
msg413515 - (view) Author: miss-islington (miss-islington) Date: 2022-02-18 22:33
New changeset 6312c1052c0186b4596fc45c42fd3ade9f8f5911 by Yilei "Dolee" Yang in branch 'main':
bpo-46784: Add newly exported expat symbols to the namespace. (GH-31397)
https://github.com/python/cpython/commit/6312c1052c0186b4596fc45c42fd3ade9f8f5911
msg413516 - (view) Author: miss-islington (miss-islington) Date: 2022-02-18 23:13
New changeset 9aca412db8343702d9199c31ba73519e6f8823b5 by Miss Islington (bot) in branch '3.9':
bpo-46784: Add newly exported expat symbols to the namespace. (GH-31397)
https://github.com/python/cpython/commit/9aca412db8343702d9199c31ba73519e6f8823b5
msg413520 - (view) Author: Gregory P. Smith (gregory.p.smith) * (Python committer) Date: 2022-02-19 00:53
New changeset e05e3d20d309603010f2c1194e612f894ad8a985 by Gregory P. Smith in branch '3.10':
[3.10] bpo-46784: Add newly exported expat symbols to the namespace. (GH-31397) (GH-31420)
https://github.com/python/cpython/commit/e05e3d20d309603010f2c1194e612f894ad8a985
msg413521 - (view) Author: Gregory P. Smith (gregory.p.smith) * (Python committer) Date: 2022-02-19 01:26
PRs for 3.7 and 3.8 remain up to release blockers.
msg413522 - (view) Author: Gregory P. Smith (gregory.p.smith) * (Python committer) Date: 2022-02-19 01:26
err "release managers" same thing right? ;)
msg413670 - (view) Author: Ned Deily (ned.deily) * (Python committer) Date: 2022-02-21 19:18
New changeset 61f3c308e435c5294e674ef59fed1d51f47e0089 by Miss Islington (bot) in branch '3.7':
bpo-46784: Add newly exported expat symbols to the namespace. (GH-31397) (GH-31418)
https://github.com/python/cpython/commit/61f3c308e435c5294e674ef59fed1d51f47e0089
msg414738 - (view) Author: Łukasz Langa (lukasz.langa) * (Python committer) Date: 2022-03-08 09:35
New changeset ccbc31ecf3a08ef626be9bbb099f0ce801142fc8 by Miss Islington (bot) in branch '3.8':
bpo-46784: Add newly exported expat symbols to the namespace. (GH-31397) (GH-31419)
https://github.com/python/cpython/commit/ccbc31ecf3a08ef626be9bbb099f0ce801142fc8
History
Date User Action Args
2022-04-11 14:59:56adminsetgithub: 90940
2022-03-08 09:35:51lukasz.langasetnosy: + lukasz.langa
messages: + msg414738
2022-02-21 19:18:36ned.deilysetnosy: + ned.deily
messages: + msg413670
2022-02-19 01:26:23gregory.p.smithsetmessages: + msg413522
2022-02-19 01:26:06gregory.p.smithsetstatus: open -> closed
messages: + msg413521

components: + Build
resolution: fixed
stage: patch review -> commit review
2022-02-19 00:53:58gregory.p.smithsetmessages: + msg413520
2022-02-18 23:33:51gregory.p.smithsetpull_requests: + pull_request29557
2022-02-18 23:13:20miss-islingtonsetmessages: + msg413516
2022-02-18 23:07:55miss-islingtonsetpull_requests: + pull_request29556
2022-02-18 23:07:51miss-islingtonsetpull_requests: + pull_request29555
2022-02-18 22:33:32miss-islingtonsetpull_requests: + pull_request29554
2022-02-18 22:33:28miss-islingtonsetpull_requests: + pull_request29553
2022-02-18 22:33:15miss-islingtonsetnosy: + miss-islington
messages: + msg413515
2022-02-18 04:36:48ned.deilysetnosy: + corona10
2022-02-17 23:47:18yileisetkeywords: + patch
stage: patch review
pull_requests: + pull_request29540
2022-02-17 23:41:02gregory.p.smithsetnosy: + gregory.p.smith
2022-02-17 23:35:45yileicreate